[IMP] account: remove analytic items from the menu when associated setting is off #4853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets the un-managed branch odoo-dev/odoo:18.0-rd-accounting-onboarding-malb, it needs to be retargeted before it can be merged. |
malb-odoo
reviewed
Nov 5, 2025
malb-odoo
left a comment
malb-odoo
left a comment
There was a problem hiding this comment.
Solution chosen is the right one ! Good job on this 😄 Let's elaborate the commit message a bit more and then it will be good to go 😄
yagho-odoo
force-pushed
the
18.0-accountingOnboarding-bugpovement-yagho
branch
from
323b722 to
c1ddbc6
Compare
yagho-odoo
changed the title
malb-odoo
reviewed
Nov 5, 2025
malb-odoo
left a comment
malb-odoo
left a comment
There was a problem hiding this comment.
Same commit message doesn't follow the guideline 😄
…tting is off When analytics were off in the accounting configuration settings, analytic items were still showing in the accounting menu, now it only appears if analytics are checked task id: 5231297
yagho-odoo
force-pushed
the
18.0-accountingOnboarding-bugpovement-yagho
branch
from
c1ddbc6 to
9f0ca55
Compare
yagho-odoo
changed the title
|
Same for the task if but let's merge this good job ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When analytics were off in the accounting configuration settings, analytic items were still showing
in the accounting menu, now it only appears if analytics are checked
task id: 5231297